Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1310: Created slots for assigning/unassigning user to groups #223

Merged
merged 1 commit into from
Dec 10, 2021
Merged

IBX-1310: Created slots for assigning/unassigning user to groups #223

merged 1 commit into from
Dec 10, 2021

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Oct 23, 2021

Question Answer
JIRA issue IBX-1310
Type bug
Target eZ Platform version v2.5
BC breaks no

The related Slots were missing for assignUserToUserGroup and unAssignUserToUserGroup UserService's methods which resulted in not indexing the related subtrees.

The required PR: ezsystems/ezpublish-kernel#3125

@barw4 barw4 added the Bug label Oct 23, 2021
@barw4 barw4 self-assigned this Oct 23, 2021
@barw4 barw4 mentioned this pull request Oct 23, 2021
Merged
6 tasks
@barw4 barw4 requested a review from a team October 26, 2021 09:28
@adamwojs adamwojs requested a review from a team October 27, 2021 09:53
@Steveb-p
Copy link
Contributor

I think this will also need a version bump in composer.json, as it uses new classes in kernel?

@barw4
Copy link
Member Author

barw4 commented Oct 27, 2021

I think this will also need a version bump in composer.json, as it uses new classes in kernel?

Isn't it always resolved when there is actually a release?

@barw4 barw4 closed this Oct 27, 2021
@barw4 barw4 reopened this Oct 27, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ViniTou ViniTou requested a review from a team October 27, 2021 12:28
@tomaszszopinski tomaszszopinski self-assigned this Dec 7, 2021
tomaszszopinski
tomaszszopinski approved these changes Dec 10, 2021
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform 2.5.

@adamwojs adamwojs merged commit e774353 into 1.7 Dec 10, 2021
@adamwojs adamwojs deleted the ibx-1310-index-user-service-actions branch December 10, 2021 08:55
@adamwojs
Copy link
Member

Could you please merge up changes?

@barw4
Copy link
Member Author

barw4 commented Dec 10, 2021 •
edited
Loading

Merged into:
2.0: 55e719a
3.3: 3d0d2a0
ibexa/solr/main PR: ibexa/solr#7

@barw4 barw4 mentioned this pull request Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@ViniTou ViniTou ViniTou approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@barw4 barw4

@tomaszszopinski tomaszszopinski

Labels
Bug QA Approved Ready for MERGE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barw4 @Steveb-p @adamwojs @ViniTou @tomaszszopinski